Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-1095: add new UD/IDE navigation experience #1508

Merged
merged 1 commit into from
Jun 17, 2016
Merged

CHE-1095: add new UD/IDE navigation experience #1508

merged 1 commit into from
Jun 17, 2016

Conversation

akurinnoy
Copy link
Contributor

Goals:

  • revamp the left navbar
  • remove the mobile responsiveness
  • add ability to jump into recent workspace
  • improve the branding/consistency between UD/IDE

Signed-off-by: Oleksii Kurinnyi okurinnyi@codenvy.com

@akurinnoy
Copy link
Contributor Author

navbar-che

}

/**
* Sends a message to the parent frame to inform that IDE ide has been loaded.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"IDE ide" -> "IDE application"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ashumilova
Copy link
Contributor

License check fails - to fix execute:
mvn license:format

</g>
</g>
</g>
</svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing EOL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

this.iframeAdded = false;
this.$timeout = $timeout;
this.$compile = $compile;

$window.addEventListener("message", function(event) {
if ("ide-loaded" == event.data) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dealt to use strict equals

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@codenvy-ci
Copy link

Build # 916 - FAILED

Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/916/ to view the results.

@benoitf
Copy link
Contributor

benoitf commented Jun 15, 2016

PR needs to be rebased (conflicts)

$navbar-menu-text-color = $mouse-gray-color
$navbar-menu-dark-text-color = $navbar-menu-icon-color
$navbar-active-menu-text-color = $light-gray-color
$navbar-section-title-color = #62687C
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these constants hardcoded there (not in che-colors.json)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added black color into che-colors.json .
Other colors are belong to specific theme of navbar and it doesn't make sense to put them to general colors list. So I move them into separate .styl file.

@codenvy-ci
Copy link

@codenvy-ci
Copy link

Build # 927 - FAILED

Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/927/ to view the results.

Goals:
- revamp the left navbar
- remove the mobile responsiveness
- add ability to jump into recent workspace
- improve the branding/consistency between UD/IDE

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
@akurinnoy akurinnoy merged commit 5244878 into master Jun 17, 2016
@codenvy-ci
Copy link

Build # 936 - FAILED

Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/936/ to view the results.

@akurinnoy akurinnoy deleted the CHE-1095 branch June 18, 2016 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants